Critiques pour Double-click Image Downloader
Double-click Image Downloader par Marnes
176 notes
- Noté 5 sur 5par Utilisateur ou utilisatrice 14582672 de Firefox, il y a 4 ans
- Noté 5 sur 5par alphapack, il y a 4 ansWriting this review to give you an idea to fix already known issue (https://addons.mozilla.org/en-US/firefox/addon/double-click-image-download/reviews/1464906/).
SOLUTION: Find a way to check if the filename contains any extension, if it doesn't then try to find the image type (AFAIK a lot of sites can do this already, so there might be a library for that) and then just add it to the filename.
Good luck :)Réponse du développeur
mis en ligne : il y a 4 ansThanks for the constructive input, but unfortunately filename extensions are not a reliable way to determine file types. They can be missing, simply incorrect (how often I've come across a .jpg that was actually a png and vice versa...), or some website-specific filename thing that happens to have a period in it so it looks like an extension. Browsers can determine the content type themselves by looking at the data, but in HTTP requests the convention is that the server must provide a human-friendly filename with a convenient extension and only the browser can make a last ditch attempt. If a server provides no meaningful name for a file triggered by this addon, then there's nothing it can do to help the situation, it's the least qualified party involved. - Noté 5 sur 5par Alice, il y a 4 ansSpectacular addon like no other. A must for someone like me. I noticed another review asking why saved images sometimes don't have an extension, which was my very question. I read your reply, and it didn't indicate to me whether or not it would be possible for the addon to default an extension in the settings or something, like automatically assign an extension of your or the user's choice to any picture. So, is that possible? Also, could you link to this addons.mozilla.org page in the description so it's easier to rate, and/or provide contact information? Thanks.
Réponse du développeur
mis en ligne : il y a 4 ansI'm glad you like it, thanks for the message. "automatically assign an extension of your or the user's choice to any picture" this is possible, but it would be incorrect and bad behavior. Blindly defaulting to adding .jpg for example to any unknown image, means e.g. a png image could get the jpg extension. Nowadays this should cause no issues, but I consider it an anti-feature because it's simply wrong, so I will not implement it, sorry. Browsers have tricks to determine an extension and will do so whenever possible. If one cannot be determined by the browser, addons are not in a better position to try it. As for the AMO link, I'm surprised firefox doesn't provide that link by itself... So I guess, I might add AMO links to the descriptions next time I work on the text. - Noté 4 sur 5par Umpahpah, il y a 4 ansHi, and thanks for all the work, that is first. The second, why I gave 3 stars, is due to 2 issues: First, it often save image without proper extension, which is a bit annoying, and second, it does not allow to save images where Save images as.... has been disabled, and I know it is not your fault, just to re-report, as I read the comments first. So, the biggest issue is extension flaw, sometimes.
Thanks for the reply - it is just then a question how the Save image as does not make that mistake....
In any way, I raised the review for one star :)Réponse du développeur
mis en ligne : il y a 4 ansThanks for the detailed feedback. As for file extensions, extensions are not actually a required thing in filenames, they're more of a loose convention. Websites tend to forego them depending on how their images are loaded (e.g. from data streams rather than files). It's the browser's responsibility to determine an extension if at all possible, based on data from the webserver if provided (such as a suggested filename, with or without extension). It's really not within an addon's power to ensure the presence of file extensions, or infer any, sorry. Réponse du développeur
mis en ligne : il y a 4 ansOnly via your browser settings. Addons are not allowed to manipulate download locations.- Noté 1 sur 5par Utilisateur ou utilisatrice 14340167 de Firefox, il y a 4 ans
- Noté 5 sur 5par Anax, il y a 4 ansαπίστευτο, κάνει ό,τι λέει. Μην ξεχάσετε να κάνετε κλικ την επιλογή να μετονομάζει τις φωτό που κατεβάζει γιατί δεν θα μπορείτε να τις δείτε.
- Noté 5 sur 5par pstrg, il y a 5 ansVery handy extension, simple and effective - use it a lot.
Even though there's a warning about a Firefox bug, would suggest to add %datetime% to renaming pattern options.
Of course, if suggestion is accepted, ISO format should be preferred (yyyy-mm-dd_hh.mm.ss).
Compliments to author.Réponse du développeur
mis en ligne : il y a 4 ansSorry for the late reply, glad you like it, thanks. I like your idea, please follow progress here: https://gitlab.com/Marnes/doubleclick-image-downloader/issues/71 - Noté 5 sur 5par Utilisateur ou utilisatrice 15423046 de Firefox, il y a 5 ans
- Noté 5 sur 5par Utilisateur ou utilisatrice 14274969 de Firefox, il y a 5 ans
- Noté 5 sur 5par Utilisateur ou utilisatrice 15238278 de Firefox, il y a 5 ansThis is a awesome app, no pop ups or other screens that you have to wait for it to load, just double-click, or with the Android, just double tap. Thank you Marnes
- Noté 4 sur 5par Sergnikow, il y a 5 ans
- Noté 4 sur 5par Zeco, il y a 5 anshello, I love this addon, but can you make notify auto close after 1 second? That would be prefect.
Réponse du développeur
mis en ligne : il y a 5 ansNotifications are controlled by firefox, addons can't change their timing, sorry. If the notifications bother you, you can turn them off. - Noté 5 sur 5par Utilisateur ou utilisatrice 14800646 de Firefox, il y a 5 ans
- Noté 4 sur 5par Utilisateur ou utilisatrice 14680850 de Firefox, il y a 5 ans
- Noté 5 sur 5par Utilisateur ou utilisatrice 13242575 de Firefox, il y a 5 ans
- Noté 4 sur 5par Utilisateur ou utilisatrice 15109533 de Firefox, il y a 5 ans
- Noté 5 sur 5par Utilisateur ou utilisatrice 15022457 de Firefox, il y a 5 ans
- Noté 5 sur 5par Taylor, il y a 5 ans
- Noté 4 sur 5par Utilisateur ou utilisatrice 14960896 de Firefox, il y a 5 ans
- Noté 5 sur 5par Utilisateur ou utilisatrice 14909960 de Firefox, il y a 5 ansBuna, foarte buna si simpla extensia. Felicitari!
- Noté 3 sur 5par Utilisateur ou utilisatrice 13231832 de Firefox, il y a 5 ansWorks. But doesn't work on shitty resources like flickr. So, in fact, it works only on sites where "save image as" available.
Réponse du développeur
mis en ligne : il y a 5 ansI'm not sure if the correlation is 100%, but you're right in that it will definitely work if "save image as" is available, and when it isn't, it'll be uncertain. I think there used to be code that looked for images more agressively so it would work more often, but then it started making virtually everything downloadable (page backgrounds, buttons, etc), which was horribly annoying too. 10/10 very fair review. :) - Noté 5 sur 5par White_Oz, il y a 5 ansWhen Mozilla allows you, Please make it work so that it remembers the last destination that you have downloaded to, so that when you click the button then the save as dialog appears with the last download location. In that way you have to only click 2 times(or one click and enter) to save an image.
Cheers!