Hello irripod, can you open an issue here ?
https://github.com/aaFn/Bookmark-search-plus-2/issues
I would need the traces contents (go to options panel for the add-on, and tick the "Activate trace" box. A readonly textarea should appear with an history of what happened.

Thanks, and sorry for the inconvenience, let's tackle it, aaFn.

PS: Hopefully bug corrected with 2.0.29 now, let me know, and sorry for the inconvenience.

Hello alexg, thank you.
As said in some other post below, this is unfortunately not possible as of Firefox 57 and higher.
Quantum does not allow any add-on action in the bookmark manager.
aaFn

Hello Stan, I guess you mean key navigation in the menus ? Similarly you'll notice that key navigation doesn't exist (yet) on bookmarks either. I'll add that later (I made a note of it -> https://github.com/aaFn/Bookmark-search-plus-2/issues/46)

Indeed, because of limitations of the new Quantum extensions, the only way is to recreate the native interface, it cannot be extended anymore ... so it is imperfect (but improving ... ).

Not sure what you mean by "reverting to the standard-mode resets the bookmarks view to the default view", can you explain a little more ?

Note: on localization, I'll do French first, promis juré :-)

Hello, as a matter of fact there is a shortcut key (displayed in the sidebar menu since FF 60.0.1).
However Ctrl+B is already assigned to open the native bookmark sidebar and cannot be redirected.
So the following keys have been assigned from the few free left I could find:

- Linux = Ctrl+Shift+B
- MAC = Alt+B (Cmd+Alt+B doesn't match with authorized key pattern .. it is rejected)
- All others, including Windows = Ctrl+Q

Cf. https://github.com/aaFn/Bookmark-search-plus-2/issues/4

Hello brain8891, your previous review on the add-on disappeared and your rating changed also. May I ask for a feedback of why ? If there's something wrong which happened with the add-on, I'd like to know to get things corrected if possible.
Thank you in advance, aaFn.

------------------ Update following reply ---------------------
[lost previous reply, not sure why .. redoing it ..]
Hello brain8891, thank you for your detailed answer.

I guess there was a glitch on GitHub, I verified, everything is accessible and working now.

On the permissions, the reason for each is very simple, and most come from limitations of the Frefox API :-(. I documented them there for public refernce to all

-> https://github.com/aaFn/Bookmark-search-plus-2/wiki/Permissions <-

as I believe this is making that post too long, hence had to redo it ..

The last permission in the list is the storage.js file you mentioned was alerted by Kaspersky. It is not executable at all.
It contains a structured set of bookmark titles, URLs and favicons. I guess one of the titles or URLs that you have bookmarked made Kaspersky react and believe there is something bad in there. If you have a doubt, open it with an editor, this is a json data file, there is no code in there and so no virus.

I hope this is clear and as transparent as possible .
If you want to get assurance by yourself, the code is open, plain text, and fully commented, so you can have a look at it at any time (take the .xpi file in your Firefox profile, add .zip to it, and open it with you preferred zip archive to look at the sources in files which are there).

You can also post issues on https://github.com/aaFn/Bookmark-search-plus-2/issues if you want more explanations.

------------------ Update following update :-) ---------------------
Hello brain8891, Kapersky is probably like any other anti-virus, it just checks files for patterns, unintelligently. It doesn't know if something is executable or data. Moreover, storage.js has the extension .js, so Kaspersky probably believes it is a javascript file while in fact it is a json data file for Firefox .. but it has no way to know.

If one of your URL's or one of your favicons has something in it corresponding to its pattern base, then it will raise the flag.
The culprit is one of the URL's most probably (I do not believe it can be in the favicons). The problem would be to know which one ... Maybe you can send Kapersky the storage.js file if you still have it somewhere and ask them to explain which part of it (so which URL / which string) is raising the alert ?
That is probably the best thing to do.

Also, BSP2 is running inside Firefox, and Firefox is doing all they can to protect you (this is why by the way the add-on needs to request the permissions you listed and for which you now have the explanation).
Add-ons therefore cannot get out of Firefox to your computer nor do harm to it.

I don't know what to say more. As always, you have to exercise your own judgement. Kaspersky or Avast or whatever else are not absolute counter measures against things in the world, they miss some of the things, and they will overdo on others ...

Hello Matteo, unfortunately, as said on the add-on main / description page, there is no management / display of bookmark tags, keywords, description field possible as Firefox does not expose those fields through its Web Extension API's.

This is a long open bug to FF (3 years) -> https://bugzilla.mozilla.org/show_bug.cgi?id=1225916

Until they are made is available by FF, it won't be possible to manage them in BSP2.

Hello eggyolk, this is because websites.resistFingerprinting (https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/privacy/websites)
is disabling proper reporting of FF version in Navigator.buildID -> https://developer.mozilla.org/en-US/docs/Web/API/Navigator/buildID

However, BSP2 needs the FF version, because I make it available on FF 56 for people wanting to use it on pre-Quantum (they are not able to go to Quantum [FF57+] due to other extensions they have which wouldn't work anymore with Quantum).
And on FF56, there are some WebExtension bookmarks features not available, for which I need to activate a special code so that I can get around those lacks.

Good news however, that particular privacy setting forces buildID to a specific impossible value on Quantum (20100101) which I can recognize, and as per documentation this setting can only happen on FF 58+, so when the code sees it, it can deduce it is running on FF 58+.

*** I will get out 2.0.25 tonight so that it will work with that privacy setting and with the Privacy settings add-on, and you can get both working side by side ***

The downside is that if at some time in the future I need to recognize an FF version superior to FF58 for new features coming from FF API, I won't be able to do that for people who have enabled that setting .. And so they may not be able to benefit from those new features.

Let me know if the new version is not working in your case.

Thank you vitaaliy. Welcome

Hello Paul Jackson, indeed and this is not due to the add-on, but to Firefox API.
See this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1396364

This is hitting peope with lots of bookmarks. Firefox devs seem to think that 95% of users have less than 2000 bookmarks, and they consider people like you (or me) as "pathological cases" :-)

Patiently waiting for things to improve on Firefox side, and trying some workarounds meanwhile .. https://github.com/aaFn/Bookmark-search-plus-2/issues/2

Sorry that I do not have a better answer, aaFn.

Thank you ohillary.
Can you detail the operation you are doing when the folder is not showing, and you need a right click to reveal ? (I guess you're talking in the search pane).
Also, are you in "simple" or "advanced" click mode ? (see Options)
Any click should show the corresponding bookmark, so if not, there is a bug which I need to correct :-)

---------------------
Edit: thank you for the update. If any problem is showing, do not hesitate to create an issue here -> https://github.com/aaFn/Bookmark-search-plus-2/issues

Hello, I can add it if this is really used.
Mind that because of FF new WebExtension API limitations, I had to recreate a user interface ... so I am incrementally enriching it as per user demand.

If you want the function, would you mind creating the demand here so that we track it ?
https://github.com/aaFn/Bookmark-search-plus-2/issues