Hello @miko, that is correct, and that will really be a relief when Mozilla will enable favicon access in Firefox API, cf. https://bugzilla.mozilla.org/show_bug.cgi?id=1315616 and https://bugzilla.mozilla.org/show_bug.cgi?id=1411120, like Chrome is doing.

Please vote on those two bugs to raise their priority with the FF team !
When it's available, I will be able to drop the code for fetching the favicons :-)

Unsafe site messages are because you have bookmarked them, and so when BSP2 tries to retrieve the favicon from those sites, this creates the problem. When FF will make favicons available, that won't happen anymore. And meanwhile, the workaround is to disable favicon fetching as you have done, or to wait that BSP2 does all bookmarks, since this only happens one time, they are all cached by BSP2 after that.

Thank you, aaFn.

Hello @Cormchij, correct, this is forbidden by Firefox, add-ons cannot access / open local files.
Have a look at the Browser console (Ctrl+Shift+J) when you click on such a bookmark in BSP2, you will see security messages in it saying Firefox prevented using the URL:

"Error: Illegal URL: file:///E:...."

Note that there seems you could have a workaround, but this requires that you modify your Firefox config: http://www.websina.com/bugzero/kb/browser-file-url.html (an add-on cannot do that of course)

Hello @Infinity, thank you :-)

Hello, if you read the add-on description page https://addons.mozilla.org/en-US/firefox/addon/bookmark-search-plus-2/, you will see it has to fetch the favicon for each bookmark to be able to display them (the little images at front of bookmarks). This is because Firefox doesn't give access to them. The add-on does that only once.
Alerts mean that you have plenty of bookmarks to malwared URLs .. :-)

You can deactivate favicon fetching in the options page, and you won't get any alert. But then all icons will be the standard "no favicon" icon. We are just waiting that Firefox gives us that access -> https://bugzilla.mozilla.org/show_bug.cgi?id=1315616

Thank you, aaFn.

Hello, yes I also fell on that recentlyl, it seems the behavior of FF bookmark search API changed a bit and is now returning two special folders I was not seeing before, and which are not expected (namely the "Tags" special folder ... but also the Mobile bookmarks special folder even when it is empty).

Since they are not expected, BSP2 believes there is a de-synchronization with the FF DB of bookmarks, and attempts a reload.

This is corrected in 2.0.76 which will be out soon ... I filtered out those two items when appropriate from the search result gotten from FF API.
Thanks aaFn.

====================== Update ===================
2.0.76 is out now with the fix for extended search responses.
Should be all ok now, sorry for the inconvenience, aaFn.

Hello @Notlaw, thank you.

The first demand is made impossible by FF for Web extensions, the Boomark History window is not customizable and no add-on can run within it, sorry.

The second one you mention is in fact hitting a bug I opened on FF some time ago https://bugzilla.mozilla.org/show_bug.cgi?id=1531539
=> we are waiting for it to be corrected by FF so that it can work.
=> Meanwhile, the work around is to drag the folder you want to move to the bookmark bar, and to drop it into the "Bookmarks Toolbar" folder inside of BSP2, at top of the bookmark tree .. and the result will be the same.

Thank you, aaFn.

Hello, thank you.
On focus, alas this is not yet possible, Firefox does not allow that -> https://bugzilla.mozilla.org/show_bug.cgi?id=1502713
Impatiently waiting that FF fixes the bug .. :-)

Hello they86, thank you. Interesting suggestions, so lets go through them one by one:

- Ok, I will add access to the options page in the right click menu of the BSP2 icon in the toolba,r for easier / faster access.

- Indeed, now that you say it, I see that the visual mouse pointer shape to distinguish an active part (favicon and text in Advanced mode), from a non active part (blank in advanced mode, or whole line on folders or whole line on bookmarks in Simple mode), is not really consistent across Simple and Advanced modes in search results.
So in 2.0.74, I am improving the behavior as follows: a pointer mouse cursor (little hand) will now only show on active parts to open bookmark (= favicon and text in Advanced mode), while a default mouse cursor will always show on non active parts to locate bookmark item (= blank in advanced mode, or whole line on folders, or whole line on bookmarks in Simple mode).
This should be visually clearer and easier.

- You are correct, an add-on cannot override the Firefox bookmark shortcut. This is Firefox security feature.

- "Shift" alone is not possible, it can only be with "Ctrl" or "Alt" .. See "Shortcut values" in https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/commands

- Ok I will see if I can also add a shortcut to open BSP2 in a tab -> https://github.com/aaFn/Bookmark-search-plus-2/issues/130

Thanks, aaFn.

Hello @blankon, you can already run BSP2 in a new tab. Simply click on the magnifier glass button in the search box, and click "Open BSP2 in a tab" in the menu. Hope this meets your need :-)

For integration with "Tree Style Tab" add-on, this would require the developer of that add-on to allow other add-ons to open sub-windows inside it, which is not the case today (to my knowledge). Maybe in future if he/she adds that integration feature ?

Thank you, aaFn.

=================== Edit ===============
In 2.0.73, I added the function to "Open BSP2 in a tab" on the right click menu of the BSP2 icon in the toolbar.
This allows you to keep "Tree Style Tab" in your sidebar, and to activate the feature without switching TST first.

This should answer your need, cheers aaFn.