DavidJCobb

About me

Developer Information
Name DavidJCobb
User since June 6, 2008
Number of add-ons developed 1 add-on
Average rating of developer's add-ons Not yet rated

Add-ons I've created

Bug 615866 Fix Requires Restart

Stops the browser from forcing links in App Tabs to open in new tabs.

Not yet rated
8 users

My Reviews

usi (User|Unified Script Injector)

Found bugs in how you handle regex includes Rated 3 out of 5 stars

You may want to add some sort of contact information, since AMO doesn't like it when people report bugs here...

If a regex contains forward slashes, your code won't recognize it as a regex. In your type_guess.js file, you split the code by forward slashes and test whether there's nothing before the first or after the second.

Maybe try this instead:

if (val.charAt(0) == "/" && val.charAt(val.length - 1) == "/") { /* it's a regex */ }

Also, elsewhere in your type_guess file, you use isValidURI, but according to MDN documentation, that would fail on URIs like "example.com", which is obviously unintended because you use page-mod which is meant to match those. In fact, now that I think about it,

----

Now, as for a proper review: the add-on works well enough, except that it doesn't log errors properly (WebIDE can't catch it, and add-ons that provide error consoles only see "Uncaught exception: undefined") and the textbox for editing scripts is a pain to use on mobile. (Set its font-family back to monospace, and disable autocomplete, autocorrect, and autocapitalize via HTML attributes.)

Share to Bottom

Unreliable. Rated 2 out of 5 stars

In newer versions of Firefox, this only seems to work about half the time.

Stylish

Rated 4 out of 5 stars

Works perfectly on desktop. However, styles can't be edited locally on mobile; they must be downloaded from the web, which is a pain for private-use, personal, and experimental styles.

Clean Links

Functional, but buggy and unmaintained Rated 2 out of 5 stars

The add-on's basic functionality works, but it's buggy and a pain to configure, and it seems abandoned.

The option to prevent the add-on from tampering with links to certain domains doesn't work reliably. In some cases, Clean Links breaks hyperlinks even when those links don't contain any targeted patterns, link to an excluded domain, and the excluded domain is part of the exclusion regex. This can be verified by disabling the add-on and refreshing the affected page.

Moreover, to change the regexes or domain lists, you have to use a one-line textbox that doesn't disable autocorrect or autocomplete, which is an enormous pain on mobile. The regexes textbox is also badly implemented, popping warnings as you type certain characters because regexes shouldn't end with certain characters (why are you verifying onkeypress and not onchange?).

This review is for a previous version of the add-on (2.7.1-signed.1-signed). 

Greenhouse

The add-on causes lag-spikes on large pages. Possible fix... Rated 3 out of 5 stars

You can optimize your calls to the jQuery highlight function, because it also accepts an array of multiple names, handling all of them during a single search of the document.

Accordingly, instead of having "script.js" call $("p").highlight(...) in a loop (one call per name), you should gather all of the politicians' names into a single array and pass that to the highlight function. This will considerably reduce the number of times you search through the DOM.

I suspect there may be other tricks you could employ (e.g. asynchronicity, placing your code in single-millisecond timeouts to avoid blocking).

This review is for a previous version of the add-on (1.1). 

FoxyTunes

Rated 4 out of 5 stars

Great add-on. I don't actually have speakers -- I've installed it as preparation -- so I'm basing my current feedback on its integration with the GUI.

Suggestions (already submitted via feedback on your site, but I figured I'd add 'em here):

1. Ability to change certain controls. Honestly, I have no use for anything but the Media Player picker, the Open File button (which, strangely, doesn't show up), and the Play/Pause button.

2. Ability to hide the show/hide arrows on the sides.

3. An options dialog -- the context menu system is cumbersome and annoying, as it must be re-opened and re-navigated after each individual setting change. A dialog would have the added advantage of being able to hide the options button on the toolbar itself.

This review is for a previous version of the add-on (3.5.9). 

Open Tab Count

Rated 4 out of 5 stars

Great. A recommendation, though: an option to always show the number of windows open (e.x. "3/1"). This way, the icon doesn't expand horizontally when a new window is opened -- I like my icons to be static, and I'm sure others do too.

Show Missing Images

Hmm... Rated 3 out of 5 stars

It's good. It works. It's not just a cheap SRC-changer -- it actually works just like a normal 404 placeholder should.

However, it is sort of rough and slightly unpolished. Whereas a normal 404 placeholder is shown with a border around it*, there is no border here, making it look kind of rough. Plus, broken images are only converted to placeholders after everything has loaded. Perhaps an onError event handler can be attached to images right as they start to load, so that when they fail they turn into 404 placeholders instantly?

* To see exactly what a placeholder would look like, try heading to Google.com and using this bookmarklet -- it'll take out the first image and let you see a 404 in detail.
javascript:alert(document.images[0].src="jhgajhfgafdg");

This next bookmarklet adds a 404 placeholder without height and width set, if you want to see what that would look like:
javascript:a=document.createElement("img");a.src="jhfahfdg";alert(document.body.appendChild(a));

This review is for a previous version of the add-on (0.1).