really cute, useful add-on but.... Ohodnoceno 3 z 5 hvězdiček

hi all

I've just this lovely little add-on ever since FF went to that weird double bookmark button design.

I've also used this add-on completely successfully with another long-term bookmark add-on called "Add Bookmark Here ²".

I've used this other add-on for so long it was a struggle to remember why but some research and investigation led me to conclude it had been because it allowed me to properly edit bookmarks AND control where they got saved, at a time when Firefox didn't let me do that (before the bookmark was saved).

Anyway, unfortunately, since star-button in urlbar went to v1.4, I've been experiencing (in my ignorance), what appeared to be my bookmark editing window seemingly randomly disappearing, while I was editing/typing the bookmark name. I thought I was randomly pressing some keyboard shortcut or something to cause this behaviour.

However, reverting to star button in urlbar v1.3 showed that it was the version change to 1.4 which appeared to be triggering the issue. Further testing appears to indicate that this auto-saving, auto-hiding or auto-closing behaviour of the bookmark editing window is default behaviour in FF47 (I tried disabling both the discussed add-ons to test the bookmarking process in FF).

Confusingly the changelog for star-button in urlbar 1.4 says:

"- marked as multi-process compatible
- Fx47+: hide bookmarks popup, if bookmark is not bookmarked yet (pre-47 way)
- Fx47+: switch position of "Done" and "Remove Bookmark" buttons"

This would imply that the hiding of the bookmarks pop-up happened before FF 47 but I'd not witnessed this before (perhaps due to Add Bookmark Here ²).

Anyway, the main thing is that reverting to v1.3 of star-button in urlbar returns the bookmarking behaviour I am familiar with.

My question is whether this closing or hiding of the bookmark editing pop-up can be prevented by this add-on in any way (in a future version)?

I suspect that perhaps the author is trying to avoid complicating the situation with add-on options (which is understandable) but perhaps this could be a way forward?

Finally, my apologies if I have misrepresented or concluded anything incorrectly here.



Regards,

Gary

PS I am very happy to discuss this with the developer and do any testing required.

PPS I've just noticed as well that if one duplicates a tab, the star-button doesn't appear in the URLbar of the additional tab (it's still present though in the original tab). The explanation is to do with another extension I use (tab mix plus). This extension allows me to configure the behaviour of the new tab button (amongst loads of other things to do with tabs). I've got it so that a duplicate tab with all the page history of the old tab gets created, when a new tab event occurs. I disabled tab mix plus and found that I can't duplicate a tab unless I use CTRL+left mouse click on the reload page icon (or middlebutton) or drag the tab to a new position and press CTRL at the same time. These actions result in a duplicate tab with page history and star-button in URLbar appears perfectly. I mention this only in case any other user sees this behaviour occurring and is puzzled.

Tento uživatel má jednu dřívější recenzi tohoto doplňku.

Must Have Add-on but... Ohodnoceno 5 z 5 hvězdiček

This Add-on is a must have, I simply can't do without it. It restores the old Bookmark star that I've come to love over the years.

Now, having said that, the add-on used to work perfectly until the latest Firefox 47.0.
Mozilla decided to screw something up, once again, so now when clicking the star to bookmark a page, presents the unnecessary dialogue with "Done" and "Remove Bookmark" in it.
I dont want to confirm my bookmark, I want to simply left-click on the star without confirmation.

Also, the "Remove Bookmark" button used to be in a different location, towards the top, now its at the bottom right side of the box.

All this used to be fine up to Firefox 46.0.1.
Now with Firefox 47, it seems things are starting to go bad.

I know this seems very trivial to most of you, but I hope the add-on gets updated to be just like it used to.

Thanks

EDIT: I cannot begin to describe how awesome you are, Aris.
Thank you so much for this beta build, it helps A LOT.
Also, thank you for the quick response too.

ty ty ty

Tato recenze je pro předchozí verzi doplňku (1.3). 

The new changes introduced in Firefox 47 are related to the button itself, but not to its position or appearance (what Star-Button In Urlbar is actually about).

Classic Theme Restorer offers an option to "mostly" hide that popup before a page is bookmarked.
I uploaded a beta build of SBIU where this feature from CTR is included. This add-on can not move "Remove Bookmark" button back to top on that popup, so switching positions with "Done" is at least more user friendly.
https://addons.mozilla.org/addon/starbuttoninurlbar/versions/1.4beta1

Wonderful Add-on Ohodnoceno 5 z 5 hvězdiček

Does exactly what it says on the tin. Great help in cleaning up the evermore cluttered Firefox main toolbar...

Tato recenze je pro předchozí verzi doplňku (1.2.1-signed.1-signed). 

Almost perfect (with workaround) Ohodnoceno 4 z 5 hvězdiček

This add-on works perfectly, with one exception. The bookmark star appears on the right side of the URL window as it should, with all the functionality that used to be available in Firefox. However, after installing the add-on, not only did it hide "the default bookmarks toolbar menu button and bookmarks menu popup" (which is ok with me and disclosed by the developer), but it also hid the icons for six other add-ons that previously appeared on the right side of the URL bar. I was able to work around this problem as follows:

Disable the Star-Button In Urlbar add-on
Restart Firefox
Go to Firefox's customize screen
Click on "Show / Hide Toolbars" and check "Bookmarks Toolbar"
Drag the default bookmarks toolbar menu button and bookmarks menu popup from the URL bar to the bookmarks toolbar
Click on "Show / Hide Toolbars" and uncheck "Bookmarks Toolbar"
Enable the Star-Button In Urlbar add-on
Restart Firefox

And voila! The star button appeared on the URL bar in the address window, and the icons for all of my other add-ons are correctly displayed on the right side of the URL bar.

I hope this helps other users who might be having the same issue I had.

And Aris, thank you for developing this add-on, which provides critical functionality that was previously a default feature of Firefox and should be again.

Tato recenze je pro předchozí verzi doplňku (1.2.1-signed.1-signed). 

Could you provide some details about your setup?
Which OS are you using?
Which other add-ons provide urlbar icons?
Can this be reproduced on a new Firefox profile?

EDIT:
Anyone who experienced this problem is welcome to test the beta build of 1.3 to verify, if the bug is fixed or still present.
https://addons.mozilla.org/addon/starbuttoninurlbar/versions/1.3beta1

Good Job! Ohodnoceno 5 z 5 hvězdiček

Simple and perfect. Works as expected.

Tato recenze je pro předchozí verzi doplňku (1.2.1-signed.1-signed). 

Ohodnoceno 5 z 5 hvězdiček

really good experience

Tato recenze je pro předchozí verzi doplňku (1.2.1-signed.1-signed). 

Genious! Ohodnoceno 5 z 5 hvězdiček

It delivers! Thanks!

Tato recenze je pro předchozí verzi doplňku (1.2.1-signed.1-signed). 

Ohodnoceno 5 z 5 hvězdiček

I love it. I miss this feature when switching from Chrome to Firefox.

Tato recenze je pro předchozí verzi doplňku (1.2.1-signed.1-signed). 

Ohodnoceno 5 z 5 hvězdiček

wow! much thanks for this great addon! :)

Tato recenze je pro předchozí verzi doplňku (1.1.1-signed.1-signed). 

Ohodnoceno 5 z 5 hvězdiček

thanks a lot, this addon makes firefox bookmark adding usable again :)

Tato recenze je pro předchozí verzi doplňku (1.1.1-signed.1-signed). 

Ohodnoceno 5 z 5 hvězdiček

Great addon, does exactly what it says. Really helped me when the new firefox updates screwed up the UI for us users...

Keep it up!

Tato recenze je pro předchozí verzi doplňku (1.1.1-signed.1-signed). 

Ohodnoceno 5 z 5 hvězdiček

Thank you! Thank you! Thank you!

Tato recenze je pro předchozí verzi doplňku (1.1.1-signed.1-signed). 

Ohodnoceno 5 z 5 hvězdiček

Thank you!

Tato recenze je pro předchozí verzi doplňku (1.1.1-signed.1-signed). 

Excellent Add-On Ohodnoceno 5 z 5 hvězdiček

Excellent Add-On
I love it
Thanks

Tato recenze je pro předchozí verzi doplňku (1.0.9.1-signed.1-signed). 

Excellent addon Ohodnoceno 5 z 5 hvězdiček

This is a great addon that fixes one of Mozilla's very silly decisions, and works exactly as advertised.

However, the addon seems to have problems with other extensions, custom themes and userChrome.css changes, and so I would propose the author make a CSS update in starinurlextra.css (this is for the Windows version, which is the only one I use):

@namespace url(http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul);
@-moz-document url(chrome://browser/content/browser.xul){
#urlbar-icons #bookmarks-menu-button .toolbarbutton-icon {
border:0 !important;
background-color:transparent !important;
list-style-image: url("chrome://star-in-urlbar/skin/windows/starbutton1.png");
-moz-image-region: rect(0px 18px 18px 0px);
}
#urlbar-icons #bookmarks-menu-button:hover .toolbarbutton-icon {
border:0 !important;
background-color:transparent !important;
list-style-image: url("chrome://star-in-urlbar/skin/windows/starbutton1.png");
background-image: radial-gradient(circle closest-side, hsla(45,100%,73%,.3), hsla(45,100%,73%,0));
-moz-image-region: rect(0px 36px 18px 18px);
}
#urlbar-icons #bookmarks-menu-button:hover:active .toolbarbutton-icon {
border:0 !important;
background-color:transparent !important;
list-style-image: url("chrome://star-in-urlbar/skin/windows/starbutton1.png");
background-image: radial-gradient(circle closest-side, hsla(45,100%,73%,.1), hsla(45,100%,73%,0));
-moz-image-region: rect(0px 54px 18px 36px);
}
#urlbar-icons #bookmarks-menu-button[starred] .toolbarbutton-icon {
border:0 !important;
background-color:transparent !important;
list-style-image: url("chrome://star-in-urlbar/skin/windows/starbutton2.png");
-moz-image-region: rect(0px 18px 18px 0px);
}
#urlbar-icons #bookmarks-menu-button[starred]:hover .toolbarbutton-icon {
border:0 !important;
background-color:transparent !important;
list-style-image: url("chrome://star-in-urlbar/skin/windows/starbutton2.png");
background-image: radial-gradient(circle closest-side, hsla(45,100%,73%,.3), hsla(45,100%,73%,0));
-moz-image-region: rect(0px 36px 18px 18px);
}
#urlbar-icons #bookmarks-menu-button[starred]:hover:active .toolbarbutton-icon {
border:0 !important;
background-color:transparent !important;
list-style-image: url("chrome://star-in-urlbar/skin/windows/starbutton2.png");
background-image: radial-gradient(circle closest-side, hsla(45,100%,73%,.1), hsla(45,100%,73%,0));
-moz-image-region: rect(0px 54px 18px 36px);
}
}

Adding border and background-color rules should (mostly) invalidate the default Firefox button styling, which is admittedly to blame for the problem, and not the extension author.



Also, adding the function of this old unsupported extension:
https://addons.mozilla.org/en-US/firefox/addon/draggable-star/
Would make this extension a must-have for every power-user out there, as well as address the complaints with the bookmark menu. I understand that may be too much work, though.

Tato recenze je pro předchozí verzi doplňku (1.0.9.1-signed.1-signed). 

Thanks for your support. I can add the extra css code, if this improves star appearance for some themes. I haven't seen anything wrong with Fx default themes.

I will look into the draggable star add-on, but most likely this feature won't be added to this extension.
SIU only moves the default bookmarks button into urlbar, it does not add any new functions or features.

Ohodnoceno 5 z 5 hvězdiček

Thank u!
I don't know what happened to my firefox29 that it just cannot add any bookmark...
But still I like this addon! :)

Tato recenze je pro předchozí verzi doplňku (1.0.8.1-signed.1-signed). 

Try to create a new profile. Fx29+ update may have corrupted it.

Ohodnoceno 5 z 5 hvězdiček

yes! this brings back the blue bookmark star (i'm on osx), and moves the dialogue box back over to the right like in pre-FF29/australis...


once again, great job, aris!

Tato recenze je pro předchozí verzi doplňku (1.0.8.1-signed.1-signed). 

Ohodnoceno 4 z 5 hvězdiček

Thank you!

Works great, but would be nice to have the star in higher resolution so that it looks good on a retina display...

Tato recenze je pro předchozí verzi doplňku (1.0.8.1-signed.1-signed). 

Ohodnoceno 5 z 5 hvězdiček

Thanks, you fixed the no customizable bookmarks button on Firefox 29! This little addon works great with any theme in Linux.

Tato recenze je pro předchozí verzi doplňku (1.0.8.1-signed.1-signed). 

Simple and effective Ohodnoceno 5 z 5 hvězdiček

Does the job nicely.
However, any chance of having the option to make the star blue in Windows to match the "Edit This Bookmark" popup?
Or alternatively turn the popup on yellow :-)

Also:
Another way of getting the bookmarks folder back on the toolbar is to move the "Bookmarks Toolbar Items" from the Bookmarks Toolbar to the Location Bar.
Then create a bookmark in the bookmarks menu with the location:

place:folder=BOOKMARKS_MENU

Then move it to the Bookmarks Toolbar folder. It should give you a button with the Bookmarks Menu contents in it.
Leave the name of the bookmark blank to have it just show as a button/folder.

Tato recenze je pro předchozí verzi doplňku (1.0.8.1-signed.1-signed). 

It should be possible by overriding button states using default image paths and icons in a Stylish profile (or maybe in userChrome.css too), but default bookmarks button only offers two icons (blue/gray) for bookmarked and not bookmarked states, while this add-on provides three states.


#urlbar-icons #bookmarks-menu-button .toolbarbutton-icon,
#urlbar-icons #bookmarks-menu-button:hover .toolbarbutton-icon,
#urlbar-icons #bookmarks-menu-button:hover:active .toolbarbutton-icon {
list-style-image: url("chrome://browser/skin/Toolbar.png") !important;
-moz-image-region: rect(0, 144px, 18px, 126px) !important;
}
#urlbar-icons #bookmarks-menu-button[starred] .toolbarbutton-icon,
#urlbar-icons #bookmarks-menu-button[starred]:hover .toolbarbutton-icon,
#urlbar-icons #bookmarks-menu-button[starred]:hover:active .toolbarbutton-icon {
list-style-image: url("chrome://browser/skin/Toolbar.png") !important;
-moz-image-region: rect(0, 162px, 18px, 144px) !important;
}

Nice trick to use a bookmarks folder to restore the bookmarks menu.